[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions tha

From: Markus Armbruster
Subject: Re: [Qemu-devel] Fwd: [PATCH v2 2/5] Change return type of functions that are named *_exit or *_exitfn in hw/char from int to void
Date: Wed, 13 Apr 2016 08:33:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 12/04/2016 20:17, Nutan Shinde wrote:
>> -static int console_exit(SCLPEvent *event)
>> +static console_exit(SCLPEvent *event)
>>  {
>> -    return 0;
> This patch doesn't even compile:
>   CC    hw/char/sclpconsole.o
> /home/pbonzini/work/upstream/qemu/hw/char/sclpconsole.c:245:8: error: return 
> type defaults to ‘int’ [-Werror=implicit-int]
>  static console_exit(SCLPEvent *event)
>         ^
> cc1: all warnings being treated as errors

It wouldn't compile even with the missing void inserted:

    hw/char/sclpconsole-lm.c:361:14: warning: assignment from incompatible 
pointer type [-Wincompatible-pointer-types]
         ec->exit = console_exit;

I gather you're doing this for BiteSizedTasks items

* Look for functions that are named *_exit or *_exitfn in hw/ and that
  return int.  They should all return zero.  Make them return void, and
  remove the checks for the callers.
* Once the above change is done, remove the "Error **" argument from
  functions named *_unrealize in hw/

Added by Paolo on 2014-12-03.  These tasks don't make sense to me.
Paolo, can you explain?

Additionally, the commit message titles aren't quite right, the series
isn't threaded, and its parts can't be applied with git-am (some MIME
crap gets in the way).

Your title lacks a subsystem: prefix and is too long.  Better:

    hw/char: Change return type of *_exit(), *_exitfn() to void

Please study http://wiki.qemu-project.org/Contribute/SubmitAPatch once
more, particularly sections "Write a meaningful commit message", "Use
git format-patch", and "Include a meaningful cover letter".

In theory, it is possible to consistently send well-formed patches
by hand.  In practice, you either use git-send-email or you screw it up.
Use git-send-email.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]