[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized var

From: Dan Carpenter
Subject: [Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized variable
Date: Thu, 14 Apr 2016 12:33:37 +0300
User-agent: Mutt/1.5.24 (2015-08-30)

It acpi_acquire_global_lock() return AE_NOT_CONFIGURED then "glk" isn't
initialized, which, if you got very unlucky, could cause a bug.

Signed-off-by: Dan Carpenter <address@hidden>

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index d999fe3..0e20116 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -77,7 +77,7 @@ static inline u16 fw_cfg_sel_endianness(u16 key)
 static inline void fw_cfg_read_blob(u16 key,
                                    void *buf, loff_t pos, size_t count)
-       u32 glk;
+       u32 glk = -1U;
        acpi_status status;
        /* If we have ACPI, ensure mutual exclusion against any potential

reply via email to

[Prev in Thread] Current Thread [Next in Thread]