[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 1/2] qemu-io: Support 'aio_
Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6 1/2] qemu-io: Support 'aio_write -z'
Fri, 15 Apr 2016 10:18:22 +0200
Am 15.04.2016 um 01:14 hat Max Reitz geschrieben:
> On 13.04.2016 13:06, Kevin Wolf wrote:
> > This allows testing blk_aio_write_zeroes().
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > qemu-io-cmds.c | 64
> > +++++++++++++++++++++++++++++++++++++++++++---------------
> > 1 file changed, 48 insertions(+), 16 deletions(-)
> Despite the continuing use of int instead of bool where the latter would
> be appropriate and of "9" instead of "BDRV_SECTOR_BITS":
I considered whether to use bool, but having a few ints and then a bool
for flags in the same struct would be inconsistent. We can have a
cleanup patch on top that changes all instances.
Same thing really with the explicit 9. I didn't even notice it, but this
is just copied code and changing it in one instance only would be
Description: PGP signature