[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6 v2] block: Don't ignore flags in blk_{,

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.6 v2] block: Don't ignore flags in blk_{, co, aio}_write_zeroes()
Date: Fri, 15 Apr 2016 09:18:59 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 04/15/2016 08:52 AM, Kevin Wolf wrote:
> Commit 57d6a428 neglected to pass the given flags to blk_aio_prwv(),
> which broke discard by WRITE SAME for scsi-disk (the UNMAP bit would be
> ignored).
> Commit fc1453cd introduced the same bug for blk_write_zeroes(). This is
> used for 'qemu-img convert' without has_zero_init (e.g. on a block
> device) and for preallocation=falloc in parallels.
> Commit 8896e088 is the version for blk_co_write_zeroes(). This function
> is only used in qemu-io.
> Reported-by: Max Reitz <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> v2:
> - There are two more places with exactly the same bug [Eric]

Not just me; Pavel spotted it first:

>  block/block-backend.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]