[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum

From: Kevin Wolf
Subject: Re: [Qemu-devel] [for-2.6] Re: [PATCH] qmp-commands.hx: document minimum speed for block jobs
Date: Fri, 15 Apr 2016 17:35:20 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 14.04.2016 um 13:08 hat Sascha Silbe geschrieben:
> Dear developers,
> Sascha Silbe <address@hidden> writes:
> > The current rate limit implementation for block jobs is ineffective
> > below a certain minimum rate. It will permit writes at least once per
> > time slice. The resulting minimum write speed (assuming source and
> > sink are fast enough in the first place) is high enough that it may
> > surprise some users, so document it. Mention that this will be fixed
> > in the future, otherwise some users might misguidedly rely on it or
> > clamp their configuration settings to the documented value.
> Forgot to mention: This is 2.6 material as it documents a known
> shortcoming that will hopefully be fixed in 2.7.

Isn't the JSON schema (qapi/block-core.json) considered the
authoritative source for interface specifications these days? I think if
we want to document the shortcomings for the time being, we should
document it in both places.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]