[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 18/19] nbd: fix assert() on qemu-nbd stop

From: Kevin Wolf
Subject: [Qemu-devel] [PULL 18/19] nbd: fix assert() on qemu-nbd stop
Date: Fri, 15 Apr 2016 19:02:21 +0200

From: Pavel Butsykin <address@hidden>

>From time to time qemu-nbd is crashing on the following assert:
    assert(state == TERMINATING);
and the state at the moment of the crash is evaluated to TERMINATE.

During shutdown process of the client the nbd_client_thread thread sends
SIGTERM signal and the main thread calls the nbd_client_closed callback.
If the SIGTERM callback will be executed after change the state to
TERMINATING, then the state will once again be TERMINATE.

To solve the issue, we must change the state to TERMINATE only if the state
is RUNNING. In the other case we are shutting down already.

Signed-off-by: Pavel Butsykin <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Max Reitz <address@hidden>
 qemu-nbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index b5751f8..2c9754e 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -215,7 +215,7 @@ static int find_partition(BlockBackend *blk, int partition,
 static void termsig_handler(int signum)
-    state = TERMINATE;
+    atomic_cmpxchg(&state, RUNNING, TERMINATE);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]