[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [1/3] powerpc: scan_features() updates incorrect bits

From: Michael Ellerman
Subject: Re: [Qemu-devel] [1/3] powerpc: scan_features() updates incorrect bits
Date: Mon, 18 Apr 2016 14:40:45 +1000

On Sat, 2016-04-16 at 00:27 +1000, Michael Ellerman wrote:
> On Fri, 2016-15-04 at 02:06:13 UTC, Unknown sender due to SPF wrote:
> > The real LE feature entry in the ibm_pa_feature struct has the
> > wrong number of elements. Instead of checking for byte 5, bit 0,
> > we check for byte 0, bit 0, and we also incorrectly update cpu user
> > feature bit 5.
> Finally the user feature, we're setting 5, ie. 0x4 | 0x1, which is:
> #define PPC_FEATURE_PPC_LE            0x00000001
> And nothing else, 0x4 is free.

Buuuut, we should reserve 0x4 for the foreseeable future. Because it is
erroneously set on older kernels.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]