[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t
Date: Mon, 18 Apr 2016 16:01:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> pio_addr_t is almost unused, because these days I/O ports are simply
> accessed through the address space.  cpu_{in,out}[bwl] themselves are
> almost unused; monitor.c and xen-hvm.c could use address_space_read/write
> directly, since they have an integer size at hand.  This leaves qtest as
> the only user of those functions.
> Not the other hand even portio_* functions use this type; the only

On the other hand?

> interesting use of pio_addr_t thus is include/hw/sysbus.h.  I guess I
> could move it there, but I don't see much benefit in that either.  Using
> uint32_t is enough and avoids the need to include ioport.h everywhere.
> Signed-off-by: Paolo Bonzini <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]