[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v3] virtio-crypto specification

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [RFC v3] virtio-crypto specification
Date: Tue, 19 Apr 2016 17:23:21 +0300

On Tue, Apr 19, 2016 at 08:37:13AM +0000, Gonglei (Arei) wrote:
> Hi all,
> This is the specification (version 3) about a new virtio crypto device. 
> Changes from v2:
>  - Reserve virtio device ID 20 for crypto device. [Cornelia]
>  - Drop all feature bits, those capabilities are offered by the device all 
> the time.  [Stefan & Cornelia]
>  - Add a new section 1.4.2 for driver requirements. [Stefan]
>  - Use definite type definition instead of enum type in some structure. 
> [Stefan]

In fact this is not how rest of spec does this:

struct virtio_net_hdr {
        u8 flags;
#define VIRTIO_NET_HDR_GSO_NONE        0
#define VIRTIO_NET_HDR_GSO_TCPV4       1
#define VIRTIO_NET_HDR_GSO_UDP         3
#define VIRTIO_NET_HDR_GSO_TCPV6       4
#define VIRTIO_NET_HDR_GSO_ECN      0x80
        u8 gso_type;
        le16 hdr_len;
        le16 gso_size;
        le16 csum_start;
        le16 csum_offset;
        le16 num_buffers;

the advantage is that field width is explicit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]