[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/10] qht: add test program

From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH 09/10] qht: add test program
Date: Wed, 20 Apr 2016 08:50:01 +0100
User-agent: mu4e 0.9.17; emacs

Emilio G. Cota <address@hidden> writes:

> On Fri, Apr 08, 2016 at 11:45:41 +0100, Alex Bennée wrote:
> (snip the entire patch)
>> A couple of notes:
>>   - these should use the gtester boiler plate for reporting results
> Done in v3.
>>   - AFAICT they are not exercising the multi-element hashing we actually
>>     use in the main code
>>   - it would be nice to add a check on the bucket/map distribution to
>>     defend against the algorithm being accidentally weakened with follow up 
>> patches
> I added tb hash chain info to 'info jit' to keep track of this. My goal
> with the test program is to check that the hash table is correct; I'd
> rather check performance with QEMU than with a made-up test, since
> it is QEMU's performance what we care about.

Fair enough. We could do with more TCG exercising test cases in the make
check but that's a different (and more difficult) problem.
> Thanks,
>               Emilio

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]