qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if no


From: Sascha Silbe
Subject: Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"
Date: Wed, 20 Apr 2016 10:37:52 +0200
User-agent: Notmuch/0.19+1~g6b3e223 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)

Dear Markus,

Markus Armbruster <address@hidden> writes:

> 'Please run this test via the "check" script' isn't an error message,
> it's advice.  Advice is appreciated, but an error message must come
> first.  I reiterate my proposal to use something like
>
>     <program_name>: TEST_DIR and QEMU_DEFAULT_MACHINE must be set in 
> environment
>     The easiest way to do that is running the test via the check script.

But I don't know how the environment (again, broader sense than just
environment variables) must be set up; that's part of the problem. I
know that at least the TEST_DIR and QEMU_DEFAULT_MACHINE environment
variables must be set, but listing those in the error message gives an
impression that it's all the user needs to do. Bad advice is worse than
no advice.

We could write something like "The TEST_DIR and QEMU_DEFAULT_MACHINE
environment variables must be set and there may be other things that the
tests may expect to have been set up. See what the 'check' script does
if you want to invoke the tests some other way than running 'check'.",
but I don't really see the additional value to the user.

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstra├če 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641




reply via email to

[Prev in Thread] Current Thread [Next in Thread]