[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/11] tcg/sparc: Make direct jump patching thre
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 09/11] tcg/sparc: Make direct jump patching thread-safe |
Date: |
Wed, 20 Apr 2016 15:23:49 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.6 |
Sergey Fedorov <address@hidden> writes:
> From: Sergey Fedorov <address@hidden>
>
> Ensure direct jump patching in SPARC is atomic by using
> atomic_read()/atomic_set() for code patching.
>
> Signed-off-by: Sergey Fedorov <address@hidden>
> Signed-off-by: Sergey Fedorov <address@hidden>
> ---
> tcg/sparc/tcg-target.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/sparc/tcg-target.inc.c b/tcg/sparc/tcg-target.inc.c
> index 54df1bc42432..629dd7bdafff 100644
> --- a/tcg/sparc/tcg-target.inc.c
> +++ b/tcg/sparc/tcg-target.inc.c
> @@ -1647,6 +1647,6 @@ void tb_set_jmp_target1(uintptr_t jmp_addr, uintptr_t
> addr)
> the code_gen_buffer can't be larger than 2GB. */
> assert(disp == (int32_t)disp);
>
> - *ptr = CALL | (uint32_t)disp >> 2;
> + atomic_set(ptr, CALL | (uint32_t)disp >> 2);
atomic_set(ptr, deposit32(CALL, 0, 30, disp >> 2))
might be a little more explicit.
Otherwise:
Reviewed-by: Alex Bennée <address@hidden>
> flush_icache_range(jmp_addr, jmp_addr + 4);
> }
--
Alex Bennée
- [Qemu-devel] [PATCH 07/11] tcg/arm: Make direct jump patching thread-safe, (continued)
- [Qemu-devel] [PATCH 07/11] tcg/arm: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- [Qemu-devel] [PATCH 04/11] tcg/ppc: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- [Qemu-devel] [PATCH 11/11] tcg: Note requirement on atomic direct jump patching, Sergey Fedorov, 2016/04/07
- [Qemu-devel] [PATCH 08/11] tcg/aarch64: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- [Qemu-devel] [PATCH 09/11] tcg/sparc: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- Re: [Qemu-devel] [PATCH 09/11] tcg/sparc: Make direct jump patching thread-safe,
Alex Bennée <=
- [Qemu-devel] [PATCH 10/11] tcg/mips: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- Re: [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe, Sergey Fedorov, 2016/04/07
- Re: [Qemu-devel] [PATCH 00/11] tcg: Make direct jump patching thread-safe, Alex Bennée, 2016/04/20