[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks fr

From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state
Date: Thu, 21 Apr 2016 15:31:33 +1000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

On 04/20/2016 12:33 PM, David Gibson wrote:
The VIOsPAPRBus structure has some callback pointers in it which aren't
used anywhere in the code.  It's not clear exactly why they were there in
the first place, but they certainly have no function now.

It is clear - incorrect QOM'fication in 3954d33ab7f82f5a5 when parts of VIOsPAPRDeviceInfo became parts of VIOsPAPRBus, you can adjust the commit log :)

Reviewed-by: Alexey Kardashevskiy <address@hidden>

Signed-off-by: David Gibson <address@hidden>
  include/hw/ppc/spapr_vio.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
index ea00c3b..380fe4f 100644
--- a/include/hw/ppc/spapr_vio.h
+++ b/include/hw/ppc/spapr_vio.h
@@ -75,8 +75,6 @@ struct VIOsPAPRDevice {
  struct VIOsPAPRBus {
      BusState bus;
      uint32_t next_reg;
-    int (*init)(VIOsPAPRDevice *dev);
-    int (*devnode)(VIOsPAPRDevice *dev, void *fdt, int node_off);

  extern VIOsPAPRBus *spapr_vio_bus_init(void);


reply via email to

[Prev in Thread] Current Thread [Next in Thread]