[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when queryi

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer
Date: Thu, 21 Apr 2016 13:45:33 +0100

On 21 April 2016 at 11:41, Sylvain Garrigues
<address@hidden> wrote:
> As the framebuffer settings are copied into the result message before
> it is reconfigured, inconsistent behavior can happen when, for instance,
> you set with a sinle message the width, height, and depth, and ask at
> the same time to allocate the buffer and get the pitch and the size.
> In this case, the reported pitch and size would be incorrect as they
> were computed with the initial values of width, height and depth, not
> the ones the client requested.

Thanks for this patch. I think at this point in the 2.6 release cycle
we should leave this for the 2.7 release, given that it doesn't affect
the booting of the older Linux and Windows versions that work on the raspi2

I'll let Andrew review the patch...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]