[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v3 04/44] nbd: Reject unknown request flags

From: Eric Blake
Subject: [Qemu-devel] [PATCH v3 04/44] nbd: Reject unknown request flags
Date: Fri, 22 Apr 2016 17:40:12 -0600

The NBD protocol says that clients should not send a command flag
that has not been negotiated (whether by the client requesting an
option during a handshake, or because we advertise support for the
flag in response to NBD_OPT_EXPORT_NAME), and that servers should
reject invalid flags with EINVAL.  We were silently ignoring the
flags instead.  The client can't rely on our behavior, since it is
their fault for passing the bad flag in the first place, but it's
better to be robust up front than to possibly behave differently
than the client was expecting with the attempted flag.

Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Alex Bligh <address@hidden>

v3: reorder in series, defer check until after NBD_CMD_WRITE payload
is consumed
 nbd/server.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/nbd/server.c b/nbd/server.c
index 6a6b5a2..731e5f4 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1063,6 +1063,11 @@ static ssize_t nbd_co_receive_request(NBDRequest *req,
         rc = -EINVAL;
         goto out;
+    if (request->type & ~NBD_CMD_MASK_COMMAND & ~NBD_CMD_FLAG_FUA) {
+        LOG("unsupported flags (got 0x%x)",
+            request->type & ~NBD_CMD_MASK_COMMAND);
+        return -EINVAL;
+    }

     rc = 0;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]