[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/5] ARM: Add numa-node-id for /memory node
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/5] ARM: Add numa-node-id for /memory node |
Date: |
Sat, 23 Apr 2016 16:02:53 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2016/4/23 15:45, Andrew Jones wrote:
>>>> @@ -456,14 +460,39 @@ static int load_dtb(hwaddr addr, const struct
>>>> arm_boot_info *binfo,
>>>> > >> goto fail;
>>>> > >> }
>>>> > >>
>>>> > >> + mem_len = (nb_numa_nodes > 0) ? numa_info[0].node_mem :
>>>> > >> binfo->ram_size;
>>>> > >> rc = qemu_fdt_setprop_sized_cells(fdt, "/memory", "reg",
>>> > >
>>> > > So node0's memory node will still be called '/memory' instead of
>>> > > '/address@hidden' like the other nodes? Shouldn't we change it too?
>>> > >
>> > Previously I deleted the /memory node creation codes in virt.c and
>> > create here, but that will cause other boards booting fail since
>> > load_dtb() is a common function. So to avoid more changes to other
>> > files, I just use current way. So is there any way to change the node
>> > name after it's created in qemu?
> I'm not sure if that's possible, but we could maybe use qemu_fdt_nop_node
> to turn /memory into a NOP node, and then add a new one?
This would be a good solution, I think. I'll update it using
qemu_fdt_nop_node.
Thanks,
--
Shannon
- Re: [Qemu-devel] [PATCH v5 2/5] ARM: Virt: Set numa-node-id for CPUs, (continued)
[Qemu-devel] [PATCH v5 1/5] ARM: Virt: Add /distance-map node for NUMA, Shannon Zhao, 2016/04/21