[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add COLO_EXIT e

From: Hailiang Zhang
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v16 21/35] qmp event: Add COLO_EXIT event to notify users while exited from COLO
Date: Mon, 25 Apr 2016 17:33:21 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 2016/4/22 22:25, Eric Blake wrote:
On 04/08/2016 12:26 AM, zhanghailiang wrote:
If some errors happen during VM's COLO FT stage, it's important to notify the 
of this event. Together with 'x_colo_lost_heartbeat', users can intervene in 
failover work immediately.
If users don't want to get involved in COLO's failover verdict,
it is still necessary to notify users that we exited COLO mode.

Cc: Markus Armbruster <address@hidden>
Cc: Michael Roth <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>

+++ b/migration/colo.c
@@ -18,6 +18,7 @@
  #include "qemu/error-report.h"
  #include "qapi/error.h"
  #include "migration/failover.h"
+#include "qapi-event.h"

  /* colo buffer */
  #define COLO_BUFFER_BASE_SIZE (4 * 1024 * 1024)
@@ -368,6 +369,18 @@ out:
      if (local_err) {
+    /*
+    * There are only two reasons we can go here, something error happened,
+    * Or users triggered failover.

s/Or users/or the user/

Otherwise looks fine. As comments are minor fixes,
Reviewed-by: Eric Blake <address@hidden>

Thanks very much, I'll fix them in next version.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]