Re: [Qemu-devel] [PATCH v3 36/44] nbd: Improve handling of shutdown requests

[Alex Bligh]

On 25 Apr 2016, at 20:20, Eric Blake <address@hidden> wrote:

>>>        } else if (fixedNewstyle) {
>> 
>> So the above is for NewStyle (not fixedNewStyle)?
> 
> The above is for fixedNewStyle when TLS is not negotiated yet; the 'else
> if' is for fixedNewStyle after TLS has been negotiated.  Prior to TLS,
> we have to special-case NBD_OPT_ABORT and actually quit.

OK. fixedNewStyle is defined as a prerequisite for TLS. I'm hoping
nothing in Qemuland ever did non-fixed NewStyle, and assuming that's
the case I would not even support it (certainly it won't play
nicely with all the other stuff you've been doing).

--
Alex Bligh

signature.asc
Description: Message signed with OpenPGP using GPGMail