[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that li

From: Bandan Das
Subject: Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain
Date: Tue, 26 Apr 2016 17:28:37 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Stefan Hajnoczi <address@hidden> writes:

> On Sun, Apr 17, 2016 at 04:29:53AM -0700, Isaac Lozano wrote:
>> If an application uses libmtp on the guest system,
>> it will complain with the warning message:
>> LIBMTP WARNING: VendorExtensionID: ffffffff
>> LIBMTP WARNING: VendorExtensionDesc: (null)
>> LIBMTP WARNING: this typically means the device is PTP (i.e. a camera) but
>> not a MTP device at all. Trying to continue anyway.
>> This is because libmtp expects a MTP Vendor Extension ID of 0x00000006 and a
>> MTP Version of 0x0064. These numbers are taken from Microsoft's MTP Vendor
>> Extension Identification Message page and are what most physical devices
>> show.
>> Signed-off-by: Isaac Lozano <address@hidden>
>> ---
>>  hw/usb/dev-mtp.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> Welcome to QEMU!
> Link to MTP Vendor Extension Identification Message page for other
> reviewers:
> https://msdn.microsoft.com/en-us/library/ff632482.aspx

I am confused why the MTP spec on usb.org specifies in that
this value should be 0xffffffff for MTP devices. Is it just not updated
or there are similar MS specific differences to watch out for ? Either
way, it seems libmtp will always be a good reference when we are stuck
with such discrepencies.

> Reviewed-by: Stefan Hajnoczi <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]