[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 06/11] block: Support streaming to an interme

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v9 06/11] block: Support streaming to an intermediate layer
Date: Thu, 28 Apr 2016 11:23:25 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 27 Apr 2016 03:04:57 PM CEST, Max Reitz <address@hidden> wrote:
>> +    /* If we are streaming to an intermediate image, we need to block
>> +     * the active layer. Due to a race condition, having several block
>> +     * jobs running in the same chain is broken and we currently don't
>> +     * support it. See here for details:
>> +     * https://lists.gnu.org/archive/html/qemu-block/2015-12/msg00180.html
>> +     */
>> +    if (active) {
>> +        bdrv_op_block_all(active, s->common.blocker);
> block_job_create() unblocks BLOCK_OP_TYPE_DATAPLANE. Maybe this should
> do the same?

I don't know the internals of how dataplane works, but I don't see that
it tries to call bdrv_reopen() so it should be safe. I'll unblock it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]