[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate
Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments
Thu, 28 Apr 2016 12:58:47 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
On 04/28/2016 12:00 PM, Markus Armbruster wrote:
>>> Have you checked Marc-André's work for overlap? Cc'ing him.
>> yeah, it's conflicting with my work. Unfortunately, since I have been
>> asked to wait since a long time, I am no longer on top of things, nor
>> what I need to wait for. I have the feeling we really want
>> qmp_dispatch() in monitor.c:
>> Eric, I have been waiting for your series to settle for getting back
>> to qapi, but it keeps growing ;) I hope you are familiar with the work
>> I did in the branch so we don't duplicate efforts.
> I'd very much prefer to give precedence to Marc-André's solution.
> I think this patch is in this series just because the previous patch
> notes a redundancy, and promises its cleanup. What about this:
> * We shelve this patch for now, and s/a later patch/a future patch/ in
> the previous patch's commit message.
> * We continue to flush Eric's QAPI queue. If we come to a point where
> we really want this patch, we insert it, and apologize to Marc-André.
> But hopefully we come to a point where Marc-André's work fits first!
> We'll refer to this patch when reviewing his solution, to make sure
> we're not losing anything.
Sounds good to me :)
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v15 01/23] qapi-visit: Add visitor.type classification, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 10/23] qmp-input: Require struct push to visit members of top dict, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 15/23] qmp: Support explicit null during visits, Eric Blake, 2016/04/27
[Qemu-devel] [PATCH v15 12/23] qapi: Document visitor interfaces, add assertions, Eric Blake, 2016/04/27
- [Qemu-devel] [PATCH v15 02A/23] fixup! qapi: Guarantee NULL obj on input visitor callback error, (continued)