[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments
Date: Thu, 28 Apr 2016 12:58:47 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 04/28/2016 12:00 PM, Markus Armbruster wrote:
>>> Have you checked Marc-André's work for overlap?  Cc'ing him.
>> yeah, it's conflicting with my work. Unfortunately, since I have been
>> asked to wait since a long time, I am no longer on top of things, nor
>> what I need to wait for. I have the feeling we really want
>> qmp_dispatch() in monitor.c:
>> https://github.com/elmarco/qemu/commit/af4158993088ee2bbf9087c440990880d7943eb1.
>> Eric, I have been waiting for your series to settle for getting back
>> to qapi, but it keeps growing ;) I hope you are familiar with the work
>> I did in the branch so we don't duplicate efforts.
> I'd very much prefer to give precedence to Marc-André's solution.
> I think this patch is in this series just because the previous patch
> notes a redundancy, and promises its cleanup.  What about this:
> * We shelve this patch for now, and s/a later patch/a future patch/ in
>   the previous patch's commit message.
> * We continue to flush Eric's QAPI queue.  If we come to a point where
>   we really want this patch, we insert it, and apologize to Marc-André.
>   But hopefully we come to a point where Marc-André's work fits first!
>   We'll refer to this patch when reviewing his solution, to make sure
>   we're not losing anything.
> Okay?

Sounds good to me :)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]