[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 02/18] qapi: Improve use of qmp/types.h

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 02/18] qapi: Improve use of qmp/types.h
Date: Fri, 29 Apr 2016 13:46:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> 'qobject-json.h' is not a QObject subtype; include this file
> directly in .c files that are using it, rather than abusing
> qmp/types.h for that purpose.
> Meanwhile, for files that include a list of individual QObject
> subtypes, it's easier to just use qmp/types.h for that purpose.

I checked that this patch doesn't add any new dependencies to .d files.

In general, I'm wary of headers including headers to save typing,
because it invites including the kitchen sink, resulting in slow
compiles.  Not this patch's (or series') problem, though.

> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]