[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 08/18] qjson: Simplify by using json-output-v

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 08/18] qjson: Simplify by using json-output-visitor
Date: Mon, 02 May 2016 14:49:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Markus Armbruster <address@hidden> writes:

> Eric Blake <address@hidden> writes:
>> Instead of rolling our own limited JSON outputter, we can just
>> wrap the more full-featured JSON output Visitor.
>> This slightly changes the output (different spacing), but the
>> result is still equivalent JSON contents.
>> Signed-off-by: Eric Blake <address@hidden>
> The file comment
>   /*
>    * QEMU JSON writer
>    *
> becomes misleading.  This isn't "the" QEMU JSON writer.  It's not even
> "a" JSON writer anymore.  It's a (QOM) object to accumulate JSON in a
> limited way.
> Why it's a *QOM* object I can't see.
> If I take the QOMness away, all that's left is a thin, trivial wrapper
> around the visitor.  Why is it useful?

Oh, now I see: you asked yourself the same question, and PATCH 10+11 are
the result.

The weekend deleted the cover letter from my memory %-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]