[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [BUG 2.6] Broken CONFIG_TPM?

From: Peter Maydell
Subject: Re: [Qemu-devel] [BUG 2.6] Broken CONFIG_TPM?
Date: Mon, 2 May 2016 17:23:02 +0100

On 29 April 2016 at 08:42, Markus Armbruster <address@hidden> wrote:
> Stefan Weil <address@hidden> writes:
>> A compilation test with clang -Weverything reported this problem:
>> config-host.h:112:20: warning: '$' in identifier
>> [-Wdollar-in-identifier-extension]
>> The line of code looks like this:
>> This is fine for Makefile code, but won't work as expected in C code.
> Broken in commit 3b8acc1 "configure: fix TPM logic".  Cc'ing Paolo.
> Impact: #ifdef CONFIG_TPM never disables code.  There are no other uses
> of CONFIG_TPM in C code.
> I had a quick peek at configure and create_config, but refrained from
> attempting to fix this, since I don't understand when exactly CONFIG_TPM
> should be defined.

Looking at 'git blame' suggests this has been wrong like this for
some years, so we don't need to scramble to fix it for 2.6.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]