[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 07/11] block: Add QMP support for streaming t

From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v9 07/11] block: Add QMP support for streaming to an intermediate layer
Date: Tue, 03 May 2016 14:53:35 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 29 Apr 2016 05:11:07 PM CEST, Kevin Wolf wrote:
>> +    if (active == NULL) {
>> +        error_setg(errp, "Cannot find top level node for '%s'", device);
>> +        goto out;
>> +    }
> Hm... On the one hand, I really like that you don't expect the user to
> provide the active layer in QMP. This allows us to remove this wart
> once we have the new op blockers.

Exactly, I still plan to stick to the API we discussed last year.

> On the other hand, this code assumes that there is only a single
> top-level node. This isn't necessarily true any more these days.

Hmm... if you give me an example I can test that scenario.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]