[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from inclu

From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h
Date: Wed, 4 May 2016 09:39:13 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On Tue, May 03, 2016 at 11:43:58PM +0530, Ashi wrote:
> On Tuesday 03 May 2016 07:31 PM, Daniel P. Berrange wrote:
> >On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote:
> >>From: Ashijeet <address@hidden>
> >>
> >>Replaced connect()/listen()/parse_host_port() in net/socket.c
> >>with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h.
> >
> >If you're going to re-work this, then I think it'd be better to
> >go straight to using socket_connect() / socket_listen() / socket_parse()
> >which are QAPI based. The inet_* function should eventually be going
> >away once everything is using the QAPI based socket_* functions, so
> >adding more usage of them is not too desirable.
> >
> Yeah sure I can do that. Also I was wondering if there is a similar function
> for bind because the task listed on wiki BiteSized also expects replacement
> of bind(). So maybe adding/defining socket_bind() in util/qemu-sockets.c and
> the header include/qemu/sockets.h be helpful.

bind() is done automatically as part of the socket_listen() function

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]