[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when queryi

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] bcm2835_property: use cached values when querying framebuffer
Date: Wed, 4 May 2016 16:19:21 +0100

On 22 April 2016 at 12:42, Sylvain Garrigues
<address@hidden> wrote:
> As the framebuffer settings are copied into the result message before it is
> reconfigured, inconsistent behavior can happen when, for instance, you set 
> with
> a single message the width, height, and depth, and ask at the same time to
> allocate the buffer and get the pitch and the size.
> In this case, the reported pitch and size would be incorrect as they were
> computed with the initial values of width, height and depth, not the ones the
> client requested.
> Signed-off-by: Sylvain Garrigues <address@hidden>
> Reviewed-by: Andrew Baumann <address@hidden>
> ---
>  hw/misc/bcm2835_property.c | 31 ++++++++++++++++++++++---------
>  1 file changed, 22 insertions(+), 9 deletions(-)

Applied to target-arm.next, thanks. (I folded a couple of long lines
that checkpatch.pl complains about.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]