[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with
Emilio G. Cota
Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht
Wed, 4 May 2016 11:36:20 -0400
On Tue, May 03, 2016 at 19:24:31 -1000, Richard Henderson wrote:
> On 05/03/2016 07:26 AM, Emilio G. Cota wrote:
> >Ouch, sorry. Won't happen again.
> >Grab the missing pre-requisite patch from:
> > http://patchwork.ozlabs.org/patch/607662/mbox/
> Well, that said, there are further conflicts within my tcg-next tree.
> If you'll rebase on
> git://github.com/rth7680/qemu.git tcg-next
> I'll queue the patchset for 2.7.
Great, will do.
BTW in the last couple of days I did some more work beyond v4:
- Added a benchmark (not a correctness test) to measure parallel
performance of QHT (recall that test/qht-test is sequential.)
- Added support for concurrent insertions as long as they're not to the
same bucket, thus getting rid of the "external lock" requirement.
This is not really needed for MTTCG because all insertions are supposed
to be serialized by tb_lock; however, the feature (1) has no negative
performance impact (just adds an unlikely() branch after lock acquisition
on insertions/removals) and (2) could be useful for future (parallel)
users of qht.
Should I send this work as follow-up patches to v4 to ease review, or
should I send a v5 with them merged in?