[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, c
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/2] migration: Move qjson.[ch] to migration/, clean up |
|
Date: |
Wed, 4 May 2016 11:08:13 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/04/2016 10:49 AM, Markus Armbruster wrote:
> qjson.[ch] is a JSON writer used by migration. Eric proposed to
> replace it by common code in his "Add qapi-to-JSON and clone visitors"
> series. David's review led to the conclusion that migration would
> prefer to keep its own JSON writer, to better serve its requirements.
> PATCH 1 move it to its proper place, and explains why it exists in a
> bit more detail. PATCH 2 simplifies it a bit.
Whose tree would this go in through?
At any rate, series:
Reviewed-by: Eric Blake <address@hidden>
but see nit on 1/2
>
> Markus Armbruster (2):
> migration: Move qjson.[ch] to migration/
> migration/qjson: Drop gratuitous use of QOM
>
> Makefile.objs | 1 -
> include/{ => migration}/qjson.h | 2 +-
> include/migration/vmstate.h | 2 +-
> migration/Makefile.objs | 1 +
> qjson.c => migration/qjson.c | 58
> +++++++++++++++--------------------------
> migration/savevm.c | 2 +-
> migration/vmstate.c | 1 -
> tests/Makefile | 2 +-
> 8 files changed, 26 insertions(+), 43 deletions(-)
> rename include/{ => migration}/qjson.h (95%)
> rename qjson.c => migration/qjson.c (70%)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature