[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] cpu-exec: Restructure cpu_exec()

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH RFC] cpu-exec: Restructure cpu_exec()
Date: Wed, 4 May 2016 08:04:53 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 05/04/2016 03:38 AM, Sergey Fedorov wrote:
From: Sergey Fedorov <address@hidden>

cpu_exec() was a huge function also sprinkled with some preprocessor
directives. It's hard to read and see the main loop crowded by all this
code. Restructure cpu_exec() by moving its conceptual parts into
separate static in-line functions. That makes it possible to see the
whole main loop at once, especially its sigsetjmp() handling part.

Signed-off-by: Sergey Fedorov <address@hidden>
Signed-off-by: Sergey Fedorov <address@hidden>

I agree that cpu_exec is a shocking horror. However, this patch is hard enough to read that it might be worth splitting. Is it easy enough to pull out each subroutine in a separate patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]