Re: [Qemu-devel] [PATCH RESEND 3/5] hw/display: QOM'ify milkymist-tmu2.c

[Peter Maydell]

On 5 May 2016 at 04:04, xiaoqiang zhao <address@hidden> wrote:
> * Drop the old SysBus init function and use instance_init
> * Move tmu2_glx_init into realize stage
>
> Signed-off-by: xiaoqiang zhao <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

> +static void milkymist_tmu2_realize(DeviceState *dev, Error **errp)
> +{
> +    MilkymistTMU2State *s = MILKYMIST_TMU2(dev);
> +
> +    if (tmu2_glx_init(s)) {
> +        error_setg(errp, "tmu2_glx_init failed.");
> +    }
>  }

The milkymist maintainer might have a suggestion for a
more informative error message here.

thanks
-- PMM