[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/3] Add ENET/Gbps Ethernet support to FEC de

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 2/3] Add ENET/Gbps Ethernet support to FEC device
Date: Thu, 5 May 2016 15:22:01 +0100

On 23 April 2016 at 11:58, Jean-Christophe Dubois <address@hidden> wrote:
> The ENET device (present in i.MX6) is "derived" from FEC and backward
> compatible with it.
> This patch add the necessary support of the added feature in the ENET
> device to allow Linux to use it (on supported processors).
> Signed-off-by: Jean-Christophe Dubois <address@hidden>
> ---
>  hw/arm/fsl-imx25.c       |   3 +
>  hw/net/imx_fec.c         | 984 
> +++++++++++++++++++++++++++++++++++------------
>  include/hw/net/imx_fec.h | 243 +++++++++---
>  3 files changed, 929 insertions(+), 301 deletions(-)

I'm afraid this patch is too large for me to review, and quickly
scanning through the patch makes it look like it's half "new
feature" and half "rewrite existing stuff". Please can you
split this up somehow so it's easier to review?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]