[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead
Re: [Qemu-devel] [PATCH] linux-user/signal.c: Use target address instead of host address for microblaze restorer
Thu, 05 May 2016 22:48:57 +0800
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
On 5/5/16 00:05, Peter Maydell wrote:
> On 29 March 2016 at 15:13, <address@hidden> wrote:
>> From: Chen Gang <address@hidden>
>> The return address is in target space, so the restorer address needs to
>> be target space, too.
>> Signed-off-by: Chen Gang <address@hidden>
>> linux-user/signal.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/linux-user/signal.c b/linux-user/signal.c
>> index 4157154..c0a6f7e 100644
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -3532,7 +3532,8 @@ static void setup_frame(int sig, struct
>> target_sigaction *ka,
>> /* Return from sighandler will jump to the tramp.
>> Negative 8 offset because return is rtsd r15, 8 */
>> - env->regs = ((unsigned long)frame->tramp) - 8;
>> + env->regs = frame_addr + offsetof(struct target_signal_frame,
>> + - 8;
>> /* Set up registers for signal handler */
> Reviewed-by: Peter Maydell <address@hidden>
Thank all of you for the 2 patches reviewing.
I guess, this month, I may have free time (at least, will not be as busy
as the previous month), I shall finish tilegx floating point insns (it
has been delayed too long).
Chen Gang (陈刚)
Managing Natural Environments is the Duty of Human Beings.