[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v5 00/11] Add param Error ** for msi_init()

From: Cao jin
Subject: [Qemu-devel] [PATCH v5 00/11] Add param Error ** for msi_init()
Date: Fri, 6 May 2016 12:20:31 +0800

This patchset is for 2.7. This version has a huge change, so I hope to
get some comments first.

The change mostly is:
1. According suggestions, modify devices` msi/msix property type.
   its type mostly bit or uint, now change it to enum OnOffAuto,
   and default to "auto". So we will know if user want msi/msix or not,
   then the process will be:

                           /-> Fail: switch to the non-msi variant
     msi = auto -> msi_init
                           \-> Success: we got msi variant

                         /-> Fail: device creation fail
     msi = on -> msi_init
                         \-> Success: we got msi variant

2. For devices who don`t have msi/msix property, following its previous
   behaviour: if msi_init`s failure is non-fatal, then fall back to INTx
   silently, or else, device creation fail.

3. pci core: Assert ENOSPC error when add capability

4. fix to all the other tiny comments

cc: Gerd Hoffmann <address@hidden>
cc: John Snow <address@hidden>
cc: Dmitry Fleytman <address@hidden>
cc: Jason Wang <address@hidden>
cc: Michael S. Tsirkin <address@hidden>
cc: Hannes Reinecke <address@hidden>
cc: Paolo Bonzini <address@hidden>
cc: Alex Williamson <address@hidden>
cc: Markus Armbruster <address@hidden>
cc: Marcel Apfelbaum <address@hidden>

Cao jin (11):
  fix some coding style problems
  change pvscsi_init_msi() type to void
  megasas: Fix
  mptsas: change .realize function name
  usb xhci: change msi/msix property type
  intel-hda: change msi property type
  mptsas: change msi property type
  megasas: change msi/msix property type
  pci bridge dev: change msi property type
  pci core: assert ENOSPC when add capability
  pci: Convert msi_init() to Error and fix callers to check it

 hw/audio/intel-hda.c               | 21 +++++++++++++-----
 hw/ide/ich.c                       | 15 ++++++++-----
 hw/net/vmxnet3.c                   | 43 +++++++++++++++----------------------
 hw/pci-bridge/ioh3420.c            | 11 ++++++++--
 hw/pci-bridge/pci_bridge_dev.c     | 21 ++++++++++++------
 hw/pci-bridge/xio3130_downstream.c | 10 +++++++--
 hw/pci-bridge/xio3130_upstream.c   |  7 +++++-
 hw/pci/msi.c                       | 24 +++++++++++++++++++--
 hw/pci/pci.c                       |  6 ++----
 hw/scsi/megasas.c                  | 44 +++++++++++++++++++++-----------------
 hw/scsi/mptsas.c                   | 26 +++++++++++++++-------
 hw/scsi/mptsas.h                   |  3 ++-
 hw/scsi/vmw_pvscsi.c               | 10 +++++----
 hw/usb/hcd-xhci.c                  | 30 ++++++++++++++++++--------
 hw/vfio/pci.c                      |  6 ++++--
 include/hw/pci/msi.h               |  3 ++-
 16 files changed, 181 insertions(+), 99 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]