[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNM

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v4 5/6] qemu-io: Add 'open -u' to set BDRV_O_UNMAP after the fact
Date: Fri, 6 May 2016 18:08:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 05.05.2016 05:42, Eric Blake wrote:
> When opening a file from the command line, qemu-io defaults
> to BDRV_O_UNMAP but allows -d to give full control to disable
> unmaps. But when opening via the 'open' command, qemu-io did
> not set BDRV_O_UNMAP, and had no way to allow it.
> Make it at least possible to symmetrically test things:
> 'qemu-io -d ignore' at the CLI now matches 'qemu-io> open'
> in batch mode, and 'qemu-io' or 'qemu-io -d unmap' at
> the CLI matches 'qemu-io> open -u'.
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  qemu-io.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Not sure why you didn't just reuse the -d option for qemu-io itself, but:

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]