[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 10/10] ui: gtk: Fix some deprecation warnings
From: |
Cole Robinson |
Subject: |
[Qemu-devel] [PATCH 10/10] ui: gtk: Fix some deprecation warnings |
Date: |
Fri, 6 May 2016 14:03:14 -0400 |
All device manager APIs are deprecated now. Much of our usage is
just to get the current pointer, so centralize that logic and use
the new seat APIs
Signed-off-by: Cole Robinson <address@hidden>
---
The remaining warnings look like they'll take a bit more effort
ui/gtk.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index d156c8a..d3d7f62 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -476,12 +476,21 @@ static void gd_refresh(DisplayChangeListener *dcl)
}
#if GTK_CHECK_VERSION(3, 0, 0)
+static GdkDevice *gd_get_pointer(GdkDisplay *dpy)
+{
+#if GTK_CHECK_VERSION(3, 20, 0)
+ return gdk_seat_get_pointer(gdk_display_get_default_seat(dpy));
+#else
+ return gdk_device_manager_get_client_pointer(
+ gdk_display_get_device_manager(dpy));
+#endif
+}
+
static void gd_mouse_set(DisplayChangeListener *dcl,
int x, int y, int visible)
{
VirtualConsole *vc = container_of(dcl, VirtualConsole, gfx.dcl);
GdkDisplay *dpy;
- GdkDeviceManager *mgr;
gint x_root, y_root;
if (qemu_input_is_absolute()) {
@@ -489,10 +498,9 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
}
dpy = gtk_widget_get_display(vc->gfx.drawing_area);
- mgr = gdk_display_get_device_manager(dpy);
gdk_window_get_root_coords(gtk_widget_get_window(vc->gfx.drawing_area),
x, y, &x_root, &y_root);
- gdk_device_warp(gdk_device_manager_get_client_pointer(mgr),
+ gdk_device_warp(gd_get_pointer(dpy),
gtk_widget_get_screen(vc->gfx.drawing_area),
x_root, y_root);
vc->s->last_x = x;
@@ -1402,7 +1410,6 @@ static void gd_grab_pointer(VirtualConsole *vc, const
char *reason)
}
#if GTK_CHECK_VERSION(3, 0, 0)
- GdkDeviceManager *mgr = gdk_display_get_device_manager(display);
gd_grab_devices(vc, true, GDK_SOURCE_MOUSE,
GDK_POINTER_MOTION_MASK |
GDK_BUTTON_PRESS_MASK |
@@ -1410,7 +1417,7 @@ static void gd_grab_pointer(VirtualConsole *vc, const
char *reason)
GDK_BUTTON_MOTION_MASK |
GDK_SCROLL_MASK,
vc->s->null_cursor);
- gdk_device_get_position(gdk_device_manager_get_client_pointer(mgr),
+ gdk_device_get_position(gd_get_pointer(display),
NULL, &vc->s->grab_x_root, &vc->s->grab_y_root);
#else
gdk_pointer_grab(gtk_widget_get_window(vc->gfx.drawing_area),
@@ -1442,9 +1449,8 @@ static void gd_ungrab_pointer(GtkDisplayState *s)
GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);
#if GTK_CHECK_VERSION(3, 0, 0)
- GdkDeviceManager *mgr = gdk_display_get_device_manager(display);
gd_grab_devices(vc, false, GDK_SOURCE_MOUSE, 0, NULL);
- gdk_device_warp(gdk_device_manager_get_client_pointer(mgr),
+ gdk_device_warp(gd_get_pointer(display),
gtk_widget_get_screen(vc->gfx.drawing_area),
vc->s->grab_x_root, vc->s->grab_y_root);
#else
--
2.7.4
- [Qemu-devel] [PATCH 00/10] ui: gtk and sdl2 fixes, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 01/10] ui: gtk: fix crash when terminal inner-border is NULL, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 05/10] configure: add echo_version helper, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 02/10] ui: sdl2: Release grab before opening console window, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 07/10] configure: report SDL version, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 06/10] configure: report GTK version, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 10/10] ui: gtk: Fix some deprecation warnings,
Cole Robinson <=
- [Qemu-devel] [PATCH 03/10] configure: build SDL if only SDL2 available, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 08/10] configure: support vte-2.91, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 04/10] configure: error on unknown --with-sdlabi value, Cole Robinson, 2016/05/06
- [Qemu-devel] [PATCH 09/10] ui: gtk: Fix a runtime warning on vte >= 0.37, Cole Robinson, 2016/05/06