Re: [Qemu-devel] [PATCH 11/52] target-m68k: allow to update flags with operation on words and bytes

[Laurent Vivier]

Le 06/05/2016 à 18:45, Richard Henderson a écrit :
> On 05/04/2016 10:11 AM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>>  target-m68k/cpu.h       |  14 ++++-
>>  target-m68k/helper.c    | 139
>> ++++++++++++++++++++++++++++++++++--------------
>>  target-m68k/translate.c |  82 ++++++++++++++--------------
>>  3 files changed, 151 insertions(+), 84 deletions(-)
> 
> I wonder if this shouldn't just be dropped, or squished into some of the
> other flags-related patches?  That said,

While I was debugging this series it was very helpful to have this patch
separated to bisect where it is broken (as it was in this one).
So I think it is good to have this one separated from the others.

> Reviewed-by: Richard Henderson <address@hidden>

Thanks,
Laurent