[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v16A 17/24] qmp: Don't reuse qmp visitor after g

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v16A 17/24] qmp: Don't reuse qmp visitor after grabbing output
Date: Tue, 10 May 2016 10:18:12 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> The testsuite was the only client that attempted to reuse a
> QmpOutputVisitor for a second visit after encountering an
> error and/or calling qmp_output_get_qobject() on a first
> visit.  The next patch is about to tighten the semantics to
> be one-shot usage of the visitor, like all other visitors
> (which will enable further simplifications down the road).
> Signed-off-by: Eric Blake <address@hidden>
> ---
> This commit is designed to completely replace commit 51750617
> on Markus' qapi-next branch; all other patches in that series
> remain unchanged and the testsuite still passes.  Doing this
> now will make it easier for my next series to introduce a
> generalized visit_free(Visitor*) instead of our current
> duplication of a per-subtype foo_visit_cleanup(FooVisitor*),
> without having to revert the addition of qmp_output_visitor_reset().

Patch looks good to me.  I massaged qapi-next as instructed.  Thanks!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]