[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBa
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend |
Date: |
Tue, 10 May 2016 12:38:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 10/05/2016 11:33, Stefan Hajnoczi wrote:
>> >
>> > I'm not sure I agree with #2, as we should move away for the
>> > super-coarse AioContext lock (it is heavyweight and it doesn't play well
>> > with multiqueue). Atomics can be used for statistics, while the
>> > time-based accounting probably should be made optional because it's
>> > heavy-weight and hard to scale.
>> >
>> > But I do agree with #1, so the idea seems good.
> I agree that lightweight options are nicer. Should I resend without #2
> in the commit description?
Well, it _is_ a valid concern until someone does the work. :)
Paolo