[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exe

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec()
Date: Tue, 10 May 2016 06:13:27 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
+#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
+        X86CPU *x86_cpu = X86_CPU(cpu);
+        if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
+            && replay_interrupt()) {
+            apic_poll_irq(x86_cpu->apic_state);

Since you're moving this around, you might as well place the x86_cpu variable in the inner-most if, next to its only use.


Reviewed-by: Richard Henderson <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]