[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 11/14] increase MAX_CPUMASK_BITS from 255 to
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH RFC 11/14] increase MAX_CPUMASK_BITS from 255 to 288 |
Date: |
Wed, 11 May 2016 17:49:21 +0200 |
On Mon, 9 May 2016 11:26:57 +0200
Igor Mammedov <address@hidden> wrote:
> so that it would be possible to increase maxcpus limit
> for x86 target. Keep spapr/virt_arm at limit they used
> to have 255.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
As said in my other post, bumping up to 1024 seems reasonable for pseries.
Would it be a problem for the x86 target ? If it is okay for you, I'd rather
try to push this separately from your series.
Anyway,
Reviewed-by: Greg Kurz <address@hidden>
> hw/arm/virt.c | 2 +-
> hw/ppc/spapr.c | 2 +-
> include/sysemu/sysemu.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 56d35c7..438e09c 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1358,7 +1358,7 @@ static void virt_machine_class_init(ObjectClass *oc,
> void *data)
> * it later in machvirt_init, where we have more information about the
> * configuration of the particular instance.
> */
> - mc->max_cpus = MAX_CPUMASK_BITS;
> + mc->max_cpus = 255;
> mc->has_dynamic_sysbus = true;
> mc->block_default_type = IF_VIRTIO;
> mc->no_cdrom = 1;
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index b69995e..d61ece2 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2280,7 +2280,7 @@ static void spapr_machine_class_init(ObjectClass *oc,
> void *data)
> mc->init = ppc_spapr_init;
> mc->reset = ppc_spapr_reset;
> mc->block_default_type = IF_SCSI;
> - mc->max_cpus = MAX_CPUMASK_BITS;
> + mc->max_cpus = 255;
> mc->no_parallel = 1;
> mc->default_boot_order = "";
> mc->default_ram_size = 512 * M_BYTE;
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 38fb3ca..5edcc72 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -185,7 +185,7 @@ extern int mem_prealloc;
> *
> * Note that cpu->get_arch_id() may be larger than MAX_CPUMASK_BITS.
> */
> -#define MAX_CPUMASK_BITS 255
> +#define MAX_CPUMASK_BITS 288
>
> #define MAX_OPTION_ROMS 16
> typedef struct QEMUOptionRom {
- [Qemu-devel] [PATCH RFC 01/14] pc: acpi: x2APIC support for MADT table, (continued)
- [Qemu-devel] [PATCH RFC 01/14] pc: acpi: x2APIC support for MADT table, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 02/14] pc: acpi: x2APIC support for SRAT table, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 04/14] pc: leave max apic_id_limit only in legacy cpu hotplug code, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 03/14] acpi: cphp: add support for x2APIC in _MAT method, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 05/14] pc: apic: move MAX_APICS check to 'apic' class, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 06/14] pc: apic_common: extend APIC ID property to 32bit, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 08/14] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 09/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 10/14] pc: clarify FW_CFG_MAX_CPUS usage comment, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 11/14] increase MAX_CPUMASK_BITS from 255 to 288, Igor Mammedov, 2016/05/09
- Re: [Qemu-devel] [PATCH RFC 11/14] increase MAX_CPUMASK_BITS from 255 to 288,
Greg Kurz <=
- [Qemu-devel] [PATCH RFC 07/14] pc: apic_common: restore APIC ID to initial ID on reset, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 12/14] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 13/14] pc: q35: bump max_cpus to 288, Igor Mammedov, 2016/05/09
- [Qemu-devel] [PATCH RFC 14/14] DO NOT APPLY: hack to make 2nd CPU APIC ID to be x2APIC one, Igor Mammedov, 2016/05/09