[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was Re: [PATCH] target-i

From: Paolo Bonzini
Subject: Re: [Qemu-devel] XSAVES in GET_SUPPORTED_CPUID (was Re: [PATCH] target-i386: add Skylake-Client cpu mode)
Date: Thu, 12 May 2016 14:06:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 12/05/2016 14:03, Eduardo Habkost wrote:
> > Item number 2 on the other hand means that it's okay to add Skylake CPU
> > models without XSAVES.  Because of the large number of kernels in the
> > wild that block XSAVES, I'm inclined to do that.
> Agreed. Now, should we name the CPU model without XSAVES
> "Skylake" or "Skylake-noXSAVES"? I'm inclined towards the latter,
> to follow the same pattern we used for "Haswell-noTSX".

Do we have a plan to add Skylake with XSAVES?  I think no, so it should
be fine to do

        .name = "Skylake",

                /* omitting CPUID_XSAVE_XSAVES because... */

Haswell-noTSX was added only because we already had a model with TSX.
If we hadn't we probably would have had:

- Haswell without TSX

- Broadwell without TSX

- Broadwell-EX with TSX (or something like that).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]