[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug onl
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types |
Date: |
Thu, 12 May 2016 15:20:51 +0200 |
On Thu, 12 May 2016 13:04:23 +0200
Peter Krempa <address@hidden> wrote:
> On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote:
> > I don't think we should do that, unless users already had time to
> > update their scripts and libvirt had time to implement code
> > supporting the new method.
> >
> > I believe libvirt (and people's scripts) use maxcpus only when
> > they want CPU hotplug, so making max_cpus > smp_cpus enable CPU
> > hotplug implicitly would probably solve the compatibility issue.
>
> Libvirt uses maxcpus only if the configuration explicitly has less
> active cpus than the maximum number. This option would be the best IMO.
>
> > If we want to deprecate the use of maxcpus to enable CPU hotplug,
> > then we can make it print a warning for a few releases, so people
> > have time to update their code.
>
> At that point libvirt also needs a way to detect that the new argument
> is supported by qemu, so we can start passing it on the command line
> basically every time we now pass 'maxcpus'.
>
> The warning will get most probably ignored by people using libvirt as
> the stdout/err of qemu is not visible to them.
Ok, to make things less complicated I'll drop machine.cpu-hotplug
and leave it always enabled as it used to be and as Michael suggested.
I'll drop following patches: 12, 13, 14, 20, 23 and respin series
>
> Peter
- Re: [Qemu-devel] [RFC 11/42] pc: add 2.7 machine, (continued)
- [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Igor Mammedov, 2016/05/02
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Eduardo Habkost, 2016/05/10
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Igor Mammedov, 2016/05/11
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Michael S. Tsirkin, 2016/05/11
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Eduardo Habkost, 2016/05/11
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Michael S. Tsirkin, 2016/05/12
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Igor Mammedov, 2016/05/12
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Eduardo Habkost, 2016/05/12
- Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Peter Krempa, 2016/05/12
- Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types,
Igor Mammedov <=
- Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Peter Krempa, 2016/05/12
- Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Igor Mammedov, 2016/05/12
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Eduardo Habkost, 2016/05/11
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Michael S. Tsirkin, 2016/05/12
- Re: [Qemu-devel] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types, Igor Mammedov, 2016/05/12
[Qemu-devel] [RFC 03/42] pc: acpi: remove AML for empty/not used GPE handlers, Igor Mammedov, 2016/05/02
[Qemu-devel] [RFC 08/42] pc: acpi: consolidate legacy CPU hotplug in one file, Igor Mammedov, 2016/05/02
[Qemu-devel] [RFC 15/42] acpi: extend ACPI interface to provide send_event hook, Igor Mammedov, 2016/05/02
[Qemu-devel] [RFC 16/42] pc: use AcpiDeviceIfClass.send_event to issue GPE events, Igor Mammedov, 2016/05/02
[Qemu-devel] [RFC 17/42] docs: update ACPI CPU hotplug spec with new protocol, Igor Mammedov, 2016/05/02