[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device

From: Corey Minyard
Subject: Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device
Date: Thu, 12 May 2016 08:32:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

On 05/12/2016 02:36 AM, Michael S. Tsirkin wrote:
On Wed, May 11, 2016 at 02:46:06PM -0500, address@hidden wrote:
From: Corey Minyard <address@hidden>

Signed-off-by: Corey Minyard <address@hidden>
  hw/ipmi/smbus_ipmi.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/ipmi/smbus_ipmi.c b/hw/ipmi/smbus_ipmi.c
index 4e7203b..3a34aaf 100644
--- a/hw/ipmi/smbus_ipmi.c
+++ b/hw/ipmi/smbus_ipmi.c
@@ -167,6 +167,7 @@ static void smbus_ipmi_realize(DeviceState *dev, Error 
      sid->fwinfo.base_address = sid->parent.i2c.address;
      sid->fwinfo.memspace = IPMI_MEMSPACE_SMBUS;
      sid->fwinfo.register_spacing = 1;
+    sid->fwinfo.acpi_parent = "\\_SB.PCI0.SMB0";
I don't think it's a good idea to spread things like PCI0
outside acpi-build.c. Why do you want to pass in the path
at all?

You have to define the namespace for the ASL definition,
and you have to give the name in the serial bus definition.
However, thinking it through some more, this name needs
to come from the I2C device, not just hard-coded here.


      ipmi_add_fwinfo(&sid->fwinfo, errp);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]