[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by defau

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v5 4/6] qemu-io: Allow unaligned access by default
Date: Thu, 12 May 2016 16:38:22 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 08.05.2016 um 05:16 hat Eric Blake geschrieben:
> There's no reason to require the user to specify a flag just so
> they can pass in unaligned numbers.  Keep 'read -p' and 'write -p'
> as no-ops so that I don't have to hunt down and update all users
> of qemu-io, but otherwise make their behavior default as 'read' and
> 'write'.  Also fix 'write -z', 'readv', 'writev', 'writev',
> 'aio_read', 'aio_write', and 'aio_write -z'.  For now, 'read -b',
> 'write -b', and 'write -c' still require alignment (and 'multiwrite',
> but that's slated to die soon).
> qemu-iotest 23 is updated to match, as the only test that was
> previously explicitly expecting an error on an unaligned request.
> Signed-off-by: Eric Blake <address@hidden>

This breaks qemu-iotests 136 for raw. It's pretty obvious that this is a
test case problem (uses unaligned requests to test error accounting), so
I'm not dropping the patch, but please do send a follow-up.

Maybe negative length and offset work as a replacement.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]