[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 1/2] target-mips: fix call to memset in soft reset co

From: Leon Alrae
Subject: [Qemu-devel] [PULL 1/2] target-mips: fix call to memset in soft reset code
Date: Fri, 13 May 2016 11:44:16 +0100

From: Aurelien Jarno <address@hidden>

Recent versions of GCC report the following error when compiling

  qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length
  equal to number of elements without multiplication by element size

This is indeed correct and due to a wrong usage of sizeof(). Fix that.

Cc: Stefan Weil <address@hidden>
Cc: Leon Alrae <address@hidden>
Cc: address@hidden
LP: https://bugs.launchpad.net/qemu/+bug/1577841
Signed-off-by: Aurelien Jarno <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Leon Alrae <address@hidden>
Signed-off-by: Leon Alrae <address@hidden>
 target-mips/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-mips/helper.c b/target-mips/helper.c
index 1004ede..cfea177 100644
--- a/target-mips/helper.c
+++ b/target-mips/helper.c
@@ -539,7 +539,7 @@ void mips_cpu_do_interrupt(CPUState *cs)
     case EXCP_SRESET:
         env->CP0_Status |= (1 << CP0St_SR);
-        memset(env->CP0_WatchLo, 0, sizeof(*env->CP0_WatchLo));
+        memset(env->CP0_WatchLo, 0, sizeof(env->CP0_WatchLo));
         goto set_error_EPC;
     case EXCP_NMI:
         env->CP0_Status |= (1 << CP0St_NMI);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]