[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/14] mirror: Allow target that already has a B

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 06/14] mirror: Allow target that already has a BlockBackend
Date: Fri, 13 May 2016 16:18:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 04.05.2016 11:39, Kevin Wolf wrote:
> We had to forbid mirroring to a target BDS that already had a BB
> attached because the node swapping at job completion would add a second
> BB and we didn't support multiple BBs on a single BDS at the time. Now
> we do, so we can lift the restriction.
> As we allow additional BlockBackends for the target, we must expect
> other users to be sending requests. There may no requests be in flight
> during the graph modification, so we have to drain those users now.
> The core part of this patch is a revert of commit 40365552.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/mirror.c             | 33 ++++++---------------------------
>  blockdev.c                 |  4 ----
>  tests/qemu-iotests/041     | 27 ---------------------------
>  tests/qemu-iotests/041.out |  4 ++--
>  4 files changed, 8 insertions(+), 60 deletions(-)

I don't really see a use case for this but I guess a ratio of 8+/60- is
enough of an argument.

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]