[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O |
Date: |
Fri, 13 May 2016 16:38:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 04.05.2016 11:39, Kevin Wolf wrote:
> This changes the mirror block job to use the job's BlockBackend for
> performing its I/O. job->bs isn't used by the mirroring code any more
> afterwards.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/mirror.c | 75
> +++++++++++++++++++++++++++++++---------------------------
> blockdev.c | 4 +---
> 2 files changed, 41 insertions(+), 38 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 23aa10e..dc66340 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
[...]
> @@ -823,10 +826,12 @@ static void mirror_start_job(BlockDriverState *bs,
> BlockDriverState *target,
> return;
> }
>
> + s->target = blk_new(&error_abort);
Same as in patch 3.
Rest looks good.
Max
> + blk_insert_bs(s->target, target);
> +
> s->replaces = g_strdup(replaces);
> s->on_source_error = on_source_error;
> s->on_target_error = on_target_error;
> - s->target = target;
> s->is_none_mode = is_none_mode;
> s->base = base;
> s->granularity = granularity;
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 11/14] block: Add blk_co_readv/writev(), (continued)
- [Qemu-devel] [PATCH 10/14] backup: Remove bs parameter from backup_do_cow(), Kevin Wolf, 2016/05/04
- [Qemu-devel] [PATCH 14/14] blockjob: Remove BlockJob.bs, Kevin Wolf, 2016/05/04
- [Qemu-devel] [PATCH 13/14] commit: Use BlockBackend for I/O, Kevin Wolf, 2016/05/04
- [Qemu-devel] [PATCH 09/14] backup: Pack Notifier within BackupBlockJob, Kevin Wolf, 2016/05/04
- [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O, Kevin Wolf, 2016/05/04
- [Qemu-devel] [PATCH 12/14] backup: Use BlockBackend for I/O, Kevin Wolf, 2016/05/04