[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capab

From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability
Date: Sun, 15 May 2016 16:10:01 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 05/06/2016 07:20 AM, Cao jin wrote:
ENOSPC is programming error, assert it for debugging.

cc: Michael S. Tsirkin <address@hidden>
cc: Marcel Apfelbaum <address@hidden>
cc: Markus Armbruster <address@hidden>
Signed-off-by: Cao jin <address@hidden>
  hw/pci/pci.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index f0f41dc..fc8b377 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2151,10 +2151,8 @@ int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,

      if (!offset) {
          offset = pci_find_space(pdev, size);
-        if (!offset) {
-            error_setg(errp, "out of PCI config space");
-            return -ENOSPC;
-        }
+        /* out of PCI config space should be programming error */

'is', not 'should be'

+        assert(offset);
      } else {
          /* Verify that capabilities don't overlap.  Note: device assignment
           * depends on this check to verify that the device is not broken.

Reviewed-by: Marcel Apfelbaum <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]