[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization cod
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code |
Date: |
Mon, 16 May 2016 16:25:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 12/05/2016 19:04, Eduardo Habkost wrote:
>>> This changes some initialization code in vl.c, qemu-img, qemu-io,
>>> > > and qemu-nbd to use &error_fatal instead of manual error
>>> > > checking/reporting.
>>> > >
>>> > > The series is based on my machine branch, available at:
>>> > > git://github.com/ehabkost/qemu.git machine
>> >
>> > Patches 1-2-6 are obvious.
> Thanks. I will apply 1-2 to my machine branch. Should I apply
> patch 6, too?
Yes, please.
>> > I'm not sure about 3-4-5, these are internal functions where the error
>> > is somewhere below "should never happen" (&error_abort)---it actually
>> > should never happen, but exiting due to SIGABRT sounds wrong. It's not
>> > the kind of function that I'd expect to have an Error** argument...
> Assuming you still want to keep the Error** argument in
> qemu_init_main_loop(), I can send a simpler patch that doesn't
> touch qemu_signal_init().
Sure, that's good!
Paolo
- [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code, Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 1/6] vl: Use &error_fatal when parsing VNC options, Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 2/6] vl: Use &error_fatal when parsing monitor options, Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 6/6] Use &error_fatal when initializing crypto on qemu-{img, io, nbd}, Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 3/6] main-loop: Use Error** to report qemu_signal_init() errors, Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 4/6] main-loop: Use &error_fatal when calling qemu_init_main_loop(), Eduardo Habkost, 2016/05/12
- [Qemu-devel] [PATCH 5/6] main-loop: Make qemu_init_main_loop() and qemu_signal_init() void, Eduardo Habkost, 2016/05/12
- Re: [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code, Paolo Bonzini, 2016/05/12